Is it a good practice to use a static variable in a Test Class and use that in the actual class instead of...





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1















I've read about using a static variable from a class in the test class but I'm wondering if this is legal enough to do.



@isTest
public class myTestClass{
public static Boolean mySwitch = false;
public static testMethod void myTestMethod1(){
// code //
}
public static testMethod void myTestMethod2(){
mySwitch = true;
// code //
}
}

public class actualClass{
public void method1(){
if(Test.isRunningTest){
//always true if its hitting from a test class.
} else if(Test.isRunningTest && myTestClass.mySwitch){
//do something from myTestMethod2
}
}
}









share|improve this question







New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
















  • 2





    What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

    – David Reed
    4 hours ago











  • I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

    – Apz
    4 hours ago


















1















I've read about using a static variable from a class in the test class but I'm wondering if this is legal enough to do.



@isTest
public class myTestClass{
public static Boolean mySwitch = false;
public static testMethod void myTestMethod1(){
// code //
}
public static testMethod void myTestMethod2(){
mySwitch = true;
// code //
}
}

public class actualClass{
public void method1(){
if(Test.isRunningTest){
//always true if its hitting from a test class.
} else if(Test.isRunningTest && myTestClass.mySwitch){
//do something from myTestMethod2
}
}
}









share|improve this question







New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
















  • 2





    What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

    – David Reed
    4 hours ago











  • I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

    – Apz
    4 hours ago














1












1








1








I've read about using a static variable from a class in the test class but I'm wondering if this is legal enough to do.



@isTest
public class myTestClass{
public static Boolean mySwitch = false;
public static testMethod void myTestMethod1(){
// code //
}
public static testMethod void myTestMethod2(){
mySwitch = true;
// code //
}
}

public class actualClass{
public void method1(){
if(Test.isRunningTest){
//always true if its hitting from a test class.
} else if(Test.isRunningTest && myTestClass.mySwitch){
//do something from myTestMethod2
}
}
}









share|improve this question







New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.












I've read about using a static variable from a class in the test class but I'm wondering if this is legal enough to do.



@isTest
public class myTestClass{
public static Boolean mySwitch = false;
public static testMethod void myTestMethod1(){
// code //
}
public static testMethod void myTestMethod2(){
mySwitch = true;
// code //
}
}

public class actualClass{
public void method1(){
if(Test.isRunningTest){
//always true if its hitting from a test class.
} else if(Test.isRunningTest && myTestClass.mySwitch){
//do something from myTestMethod2
}
}
}






apex unit-test code-coverage






share|improve this question







New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question







New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question






New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked 4 hours ago









ApzApz

61




61




New contributor




Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Apz is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.








  • 2





    What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

    – David Reed
    4 hours ago











  • I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

    – Apz
    4 hours ago














  • 2





    What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

    – David Reed
    4 hours ago











  • I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

    – Apz
    4 hours ago








2




2





What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

– David Reed
4 hours ago





What code/why are you trying to gate in test context? That's something one generally ought to do only if one really has to and has run out of other tools, in my opinion.

– David Reed
4 hours ago













I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

– Apz
4 hours ago





I'm sorry but can't share my code here. I can explain why am trying to do this, let's say there is an if condition which can't be made true from a test class but can be done using Test.isRunningTest() in actual class. What this does now is that, it will always get into this if condition but not the next if-else conditions. My bad if this is confusing.

– Apz
4 hours ago










2 Answers
2






active

oldest

votes


















2














You cannot reference a test class from a production class. You have the pattern reversed on where the Boolean flag should be.



You should avoid code which runs only out of a test context wherever possible. There are a few exceptions, such as:




  • Disabling a trigger framework to save on run times if they become prohibitive

  • Disabling batch chaining or other aspects of asynchronous processing


In these cases, you still should not use Test.isRunningTest() (at least according to our coding guideline where I work). Instead, you should use a @TestVisible flag in your production code.



public with sharing class MyClass
{
@TestVisible static Boolean shouldDoStuff = true;
public static void doStuff()
{
if (!shouldDoStuff) return;

// actual logic
}
public static void doNonGatedStuff()
{
doStuff();

// other logic
}
}
@IsTest class MyClass
{
@IsTest static void testDoStuff()
{
MyClass.shouldDoStuff = false;

// rest of test
}
}


Sometimes you will see this logic reversed. For example our typical flag for trigger handlers is called bypassTrigger, which would obviously default to false. You set it to true before inserting some records for setup, then bookend it back to false so that any further operations will still run the trigger.






share|improve this answer


























  • P.S. You didn't actually answer the question of "if this is legal?"

    – sfdcfox
    4 hours ago











  • Because the way it was written wouldn't work, I simply showed how it can be done.

    – Adrian Larson
    4 hours ago



















0














No, it is not valid. You cannot access any variables or methods inside a class marked @isTest outside of a test context. Instead, you need to place the static variable inside the actual class, then modify it in the test class:



@isTest
public class myTestClass{
public static testMethod void myTestMethod1(){
// code //
}
public static testMethod void myTestMethod2(){
actualClass.mySwitch = true;
// code //
}
}

public class actualClass{
@TestVisible static Boolean mySwitch = false;
public void method2(){
if(mySwitch){
//do something from myTestMethod2
}
}
}


You can use @TestVisible to prevent accessing the variable outside of testing context.






share|improve this answer


























    Your Answer








    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "459"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: false,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });






    Apz is a new contributor. Be nice, and check out our Code of Conduct.










    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsalesforce.stackexchange.com%2fquestions%2f257558%2fis-it-a-good-practice-to-use-a-static-variable-in-a-test-class-and-use-that-in-t%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2














    You cannot reference a test class from a production class. You have the pattern reversed on where the Boolean flag should be.



    You should avoid code which runs only out of a test context wherever possible. There are a few exceptions, such as:




    • Disabling a trigger framework to save on run times if they become prohibitive

    • Disabling batch chaining or other aspects of asynchronous processing


    In these cases, you still should not use Test.isRunningTest() (at least according to our coding guideline where I work). Instead, you should use a @TestVisible flag in your production code.



    public with sharing class MyClass
    {
    @TestVisible static Boolean shouldDoStuff = true;
    public static void doStuff()
    {
    if (!shouldDoStuff) return;

    // actual logic
    }
    public static void doNonGatedStuff()
    {
    doStuff();

    // other logic
    }
    }
    @IsTest class MyClass
    {
    @IsTest static void testDoStuff()
    {
    MyClass.shouldDoStuff = false;

    // rest of test
    }
    }


    Sometimes you will see this logic reversed. For example our typical flag for trigger handlers is called bypassTrigger, which would obviously default to false. You set it to true before inserting some records for setup, then bookend it back to false so that any further operations will still run the trigger.






    share|improve this answer


























    • P.S. You didn't actually answer the question of "if this is legal?"

      – sfdcfox
      4 hours ago











    • Because the way it was written wouldn't work, I simply showed how it can be done.

      – Adrian Larson
      4 hours ago
















    2














    You cannot reference a test class from a production class. You have the pattern reversed on where the Boolean flag should be.



    You should avoid code which runs only out of a test context wherever possible. There are a few exceptions, such as:




    • Disabling a trigger framework to save on run times if they become prohibitive

    • Disabling batch chaining or other aspects of asynchronous processing


    In these cases, you still should not use Test.isRunningTest() (at least according to our coding guideline where I work). Instead, you should use a @TestVisible flag in your production code.



    public with sharing class MyClass
    {
    @TestVisible static Boolean shouldDoStuff = true;
    public static void doStuff()
    {
    if (!shouldDoStuff) return;

    // actual logic
    }
    public static void doNonGatedStuff()
    {
    doStuff();

    // other logic
    }
    }
    @IsTest class MyClass
    {
    @IsTest static void testDoStuff()
    {
    MyClass.shouldDoStuff = false;

    // rest of test
    }
    }


    Sometimes you will see this logic reversed. For example our typical flag for trigger handlers is called bypassTrigger, which would obviously default to false. You set it to true before inserting some records for setup, then bookend it back to false so that any further operations will still run the trigger.






    share|improve this answer


























    • P.S. You didn't actually answer the question of "if this is legal?"

      – sfdcfox
      4 hours ago











    • Because the way it was written wouldn't work, I simply showed how it can be done.

      – Adrian Larson
      4 hours ago














    2












    2








    2







    You cannot reference a test class from a production class. You have the pattern reversed on where the Boolean flag should be.



    You should avoid code which runs only out of a test context wherever possible. There are a few exceptions, such as:




    • Disabling a trigger framework to save on run times if they become prohibitive

    • Disabling batch chaining or other aspects of asynchronous processing


    In these cases, you still should not use Test.isRunningTest() (at least according to our coding guideline where I work). Instead, you should use a @TestVisible flag in your production code.



    public with sharing class MyClass
    {
    @TestVisible static Boolean shouldDoStuff = true;
    public static void doStuff()
    {
    if (!shouldDoStuff) return;

    // actual logic
    }
    public static void doNonGatedStuff()
    {
    doStuff();

    // other logic
    }
    }
    @IsTest class MyClass
    {
    @IsTest static void testDoStuff()
    {
    MyClass.shouldDoStuff = false;

    // rest of test
    }
    }


    Sometimes you will see this logic reversed. For example our typical flag for trigger handlers is called bypassTrigger, which would obviously default to false. You set it to true before inserting some records for setup, then bookend it back to false so that any further operations will still run the trigger.






    share|improve this answer















    You cannot reference a test class from a production class. You have the pattern reversed on where the Boolean flag should be.



    You should avoid code which runs only out of a test context wherever possible. There are a few exceptions, such as:




    • Disabling a trigger framework to save on run times if they become prohibitive

    • Disabling batch chaining or other aspects of asynchronous processing


    In these cases, you still should not use Test.isRunningTest() (at least according to our coding guideline where I work). Instead, you should use a @TestVisible flag in your production code.



    public with sharing class MyClass
    {
    @TestVisible static Boolean shouldDoStuff = true;
    public static void doStuff()
    {
    if (!shouldDoStuff) return;

    // actual logic
    }
    public static void doNonGatedStuff()
    {
    doStuff();

    // other logic
    }
    }
    @IsTest class MyClass
    {
    @IsTest static void testDoStuff()
    {
    MyClass.shouldDoStuff = false;

    // rest of test
    }
    }


    Sometimes you will see this logic reversed. For example our typical flag for trigger handlers is called bypassTrigger, which would obviously default to false. You set it to true before inserting some records for setup, then bookend it back to false so that any further operations will still run the trigger.







    share|improve this answer














    share|improve this answer



    share|improve this answer








    edited 3 hours ago

























    answered 4 hours ago









    Adrian LarsonAdrian Larson

    110k19120256




    110k19120256













    • P.S. You didn't actually answer the question of "if this is legal?"

      – sfdcfox
      4 hours ago











    • Because the way it was written wouldn't work, I simply showed how it can be done.

      – Adrian Larson
      4 hours ago



















    • P.S. You didn't actually answer the question of "if this is legal?"

      – sfdcfox
      4 hours ago











    • Because the way it was written wouldn't work, I simply showed how it can be done.

      – Adrian Larson
      4 hours ago

















    P.S. You didn't actually answer the question of "if this is legal?"

    – sfdcfox
    4 hours ago





    P.S. You didn't actually answer the question of "if this is legal?"

    – sfdcfox
    4 hours ago













    Because the way it was written wouldn't work, I simply showed how it can be done.

    – Adrian Larson
    4 hours ago





    Because the way it was written wouldn't work, I simply showed how it can be done.

    – Adrian Larson
    4 hours ago













    0














    No, it is not valid. You cannot access any variables or methods inside a class marked @isTest outside of a test context. Instead, you need to place the static variable inside the actual class, then modify it in the test class:



    @isTest
    public class myTestClass{
    public static testMethod void myTestMethod1(){
    // code //
    }
    public static testMethod void myTestMethod2(){
    actualClass.mySwitch = true;
    // code //
    }
    }

    public class actualClass{
    @TestVisible static Boolean mySwitch = false;
    public void method2(){
    if(mySwitch){
    //do something from myTestMethod2
    }
    }
    }


    You can use @TestVisible to prevent accessing the variable outside of testing context.






    share|improve this answer






























      0














      No, it is not valid. You cannot access any variables or methods inside a class marked @isTest outside of a test context. Instead, you need to place the static variable inside the actual class, then modify it in the test class:



      @isTest
      public class myTestClass{
      public static testMethod void myTestMethod1(){
      // code //
      }
      public static testMethod void myTestMethod2(){
      actualClass.mySwitch = true;
      // code //
      }
      }

      public class actualClass{
      @TestVisible static Boolean mySwitch = false;
      public void method2(){
      if(mySwitch){
      //do something from myTestMethod2
      }
      }
      }


      You can use @TestVisible to prevent accessing the variable outside of testing context.






      share|improve this answer




























        0












        0








        0







        No, it is not valid. You cannot access any variables or methods inside a class marked @isTest outside of a test context. Instead, you need to place the static variable inside the actual class, then modify it in the test class:



        @isTest
        public class myTestClass{
        public static testMethod void myTestMethod1(){
        // code //
        }
        public static testMethod void myTestMethod2(){
        actualClass.mySwitch = true;
        // code //
        }
        }

        public class actualClass{
        @TestVisible static Boolean mySwitch = false;
        public void method2(){
        if(mySwitch){
        //do something from myTestMethod2
        }
        }
        }


        You can use @TestVisible to prevent accessing the variable outside of testing context.






        share|improve this answer















        No, it is not valid. You cannot access any variables or methods inside a class marked @isTest outside of a test context. Instead, you need to place the static variable inside the actual class, then modify it in the test class:



        @isTest
        public class myTestClass{
        public static testMethod void myTestMethod1(){
        // code //
        }
        public static testMethod void myTestMethod2(){
        actualClass.mySwitch = true;
        // code //
        }
        }

        public class actualClass{
        @TestVisible static Boolean mySwitch = false;
        public void method2(){
        if(mySwitch){
        //do something from myTestMethod2
        }
        }
        }


        You can use @TestVisible to prevent accessing the variable outside of testing context.







        share|improve this answer














        share|improve this answer



        share|improve this answer








        edited 3 hours ago

























        answered 4 hours ago









        sfdcfoxsfdcfox

        264k13211458




        264k13211458






















            Apz is a new contributor. Be nice, and check out our Code of Conduct.










            draft saved

            draft discarded


















            Apz is a new contributor. Be nice, and check out our Code of Conduct.













            Apz is a new contributor. Be nice, and check out our Code of Conduct.












            Apz is a new contributor. Be nice, and check out our Code of Conduct.
















            Thanks for contributing an answer to Salesforce Stack Exchange!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fsalesforce.stackexchange.com%2fquestions%2f257558%2fis-it-a-good-practice-to-use-a-static-variable-in-a-test-class-and-use-that-in-t%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            How to label and detect the document text images

            Vallis Paradisi

            Tabula Rosettana