Does this function send ether from the contract or from the message sender?












1















Solidity newbie here...:



 function transfer(address payable to, address sender) public onlyadmin {

         to.transfer(msg.value);



     }


what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!






solidity security







share|improve this question



























    1















    Solidity newbie here...:



     function transfer(address payable to, address sender) public onlyadmin {
    
         to.transfer(msg.value);
    

    
     }


    what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!






    solidity security







    share|improve this question

























      1












      1








      1








      Solidity newbie here...:



       function transfer(address payable to, address sender) public onlyadmin {
      
         to.transfer(msg.value);
      

      
     }


      what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!






      solidity security







      share|improve this question














      Solidity newbie here...:



       function transfer(address payable to, address sender) public onlyadmin {
      
         to.transfer(msg.value);
      

      
     }


      what I want to achieve is sending from the contract's balance so I guess this.balance should be the correct way and not msg.value? Thanks!






      solidity security




      solidity security






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 5 hours ago









      kpopguykpopguy

      193




      193






















          1 Answer
          1






          active

          oldest

          votes


















          2














          Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.



          msg.value is the amount of Ether send along with the message.
          If you want to send all money of the contract you have to write something like that:



          function f(address payable beneficiary) public {
          
    beneficiary.transfer(address(this).balance);
          
}


          If you write something like that:



          function f(address payable beneficiary) payable public {
          
    beneficiary.transfer(msg.value);
          
}


          Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.






          share|improve this answer

























            Your Answer








            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "642"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f65824%2fdoes-this-function-send-ether-from-the-contract-or-from-the-message-sender%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            2














            Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.



            msg.value is the amount of Ether send along with the message.
            If you want to send all money of the contract you have to write something like that:



            function f(address payable beneficiary) public {
            
    beneficiary.transfer(address(this).balance);
            
}


            If you write something like that:



            function f(address payable beneficiary) payable public {
            
    beneficiary.transfer(msg.value);
            
}


            Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.






            share|improve this answer






























              2














              Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.



              msg.value is the amount of Ether send along with the message.
              If you want to send all money of the contract you have to write something like that:



              function f(address payable beneficiary) public {
              
    beneficiary.transfer(address(this).balance);
              
}


              If you write something like that:



              function f(address payable beneficiary) payable public {
              
    beneficiary.transfer(msg.value);
              
}


              Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.






              share|improve this answer




























                2












                2








                2







                Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.



                msg.value is the amount of Ether send along with the message.
                If you want to send all money of the contract you have to write something like that:



                function f(address payable beneficiary) public {
                
    beneficiary.transfer(address(this).balance);
                
}


                If you write something like that:



                function f(address payable beneficiary) payable public {
                
    beneficiary.transfer(msg.value);
                
}


                Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.






                share|improve this answer















                Transfer moves money from contract's account to the beneficiary one, while balance is a lookup function that takes one arbitrary address as input and gives back its balance.



                msg.value is the amount of Ether send along with the message.
                If you want to send all money of the contract you have to write something like that:



                function f(address payable beneficiary) public {
                
    beneficiary.transfer(address(this).balance);
                
}


                If you write something like that:



                function f(address payable beneficiary) payable public {
                
    beneficiary.transfer(msg.value);
                
}


                Whenever, the msg.sender sends msg.value Wei to the contract. The latter transfers the money to the beneficiary. In this case the smart contract is a broker that gives the received money to the beneficiary one.







                share|improve this answer














                share|improve this answer



                share|improve this answer








                edited 1 hour ago

























                answered 3 hours ago









                BriomkezBriomkez

                9731324




                9731324






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Ethereum Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid …



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fethereum.stackexchange.com%2fquestions%2f65824%2fdoes-this-function-send-ether-from-the-contract-or-from-the-message-sender%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    -

                    Popular posts from this blog

                    How to label and detect the document text images

                    Image
                    1 $begingroup$ This is what I mean as document text image: I want to label the texts in image as separate blocks and my model should detect these labels as classes. NOTE: This is how the end result should be like: The labels like Block 1, Block 2, Block 3,.. should be Logo, Title, Date,.. Others, etc. Work done: First approach : I tried to implement this method via Object Detection, it didn't work. It didn't even detect any text. Second approach : Then I tried it using PixelLink. As this model is build for scene text detection, it detected each and every text in the image. But this method can detect multiple lines of text if the threshold values are increased. But I have no idea how do I add labels to the text blocks. PIXEL_CLS_WEIGHT_all_ones = 'PIXEL_CLS_WEIGHT_all_ones' PIXEL_C...
                    Read more

                    Vallis Paradisi

                    Image
                    Coordinata: .mw-parser-output .geo-default,.mw-parser-output .geo-dms,.mw-parser-output .geo-dec{display:inline}.mw-parser-output .geo-nondefault,.mw-parser-output .geo-multi-punct{display:none}.mw-parser-output .longitude,.mw-parser-output .latitude{white-space:nowrap} 33°03′S 71°37′W  /  33.05°S 71.617°W  / -33.05; -71.617 Vallis Paradisi Res apud Vicidata repertae: Civitas : Chilia Numerus incolarum : 296 655 Zona horaria : UTC-4 Situs interretialis Nomen officiale : Valparaíso Gubernium Consilium : municipal council of Valparaíso Geographia Superficies : 401 600 000 Metrum quadratum Coniunctiones urbium Urbes gemellae : Ovetum , Badalona , Santa Fe , Ora longa , Sciamhaevum , Quantunia , Callao , Bat Yam , Melaka , Novorossiysk , Busan , Corduba , Odessa , Rosario , Malacca , Barcino , Soteropolis , Franciscopolis (California) , Guanajuato, Silao Tabula aut despectus Despectus in portum sinumque et urbem Vallis Paradisi Vallis Para...
                    Read more

                    Tabula Rosettana

                    Image
                    Tabula multilinguis Rosettana in Museo Britannico ostenditur. Tabula Rosettana, [1] etiam titulo OGIS 90 agnita, est stela decreto de rebus sacris in Aegypto anno 196 a.C.n. lato inscripta. Tabula iuxta Rosettam Aegypti, urbem in delta Nili et ad oram maris Mediterranei iacentem, anno 1799 a milite Francico reperta est. Inventio stelae, linguis duabus scripturisque tribus inscriptae, eruditis Instituti Aegypti statim nuntiata est; ibi enim iussu imperatoris Napoleonis eruditi omnium scientiarum (sub aegide Commissionis Scientiarum et Artium) properaverant cum expeditione Francica. Qua a Britannis mox debellata, tabula Rosettana Londinium missa hodie apud Museum Britannicum iacet. Textus Graecus cito lectus interpretationi textuum Aegyptiorum (in formis hieroglyphica et demotica expressorum) gradatim adiuvit. Denique textum plene interpretatus est Ioannes Franciscus Champollion. Ab opere eruditorum cumulativo coepit hodiernus scripturae hieroglyphicae linguaeque Aegyptiae a...
                    Read more